List and Search Blacklist IP Addresses #18
Conversation
the return statement in the if clause already guards against executing the code outside the clause
The upstream test file has changed
this will avoid redundancy in code that need to redeclare the same variables
this allows the caller to add one or more ips to the blacklist
exist subcommand checks if the given ip exists in the blacklist returns true if it exists otherwise false
checks whether the cli params passed in are also equal to 2 to cater for the blacklist 'exists' subcommand whose cli params length is exactly 2
initially passed in the subcommand value instead of the ip value whose index is 1
|
Is it finished and tested? Please also make sure that all checks pass. |
removed unused column slice
Sure will do. |
|
Let me add tests for the new blacklist features.Had tested them manually. oops! |
|
This condition is a bit useless: Also keep in mind that you need to clear the log for assertions, if they could potentially be contained in previous responses. As this test does not require the login flow, can you put it in a different test case, so that it can potentially be run in parallel? Would be great if you could as well add a test case that checks if the blacklist actually blocks a user (eg blocking localhost, surfing and verifying that the connection fails, then unblocking and trying again). |
Found this error today when running the tests. I am not sure about the username, earlier the tests were passing but after testing for the third time in a row, this came up. |
|
Looks like it should pass - maybe thats due to some local constraints? |
This PR adds three features to the blacklist command. One can now: