Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Pass Polling Config to iam instance profile step #399

Conversation

imcdo
Copy link
Contributor

@imcdo imcdo commented Jun 9, 2023

Pass in the global polling config into the iam instance profile step. Do this so configurations get used when trying to create a temporary iam role for the builder.
Closes #398

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 9, 2023

CLA assistant check
All committers have signed the CLA.

@imcdo imcdo marked this pull request as ready for review June 9, 2023 01:02
@imcdo imcdo requested a review from a team as a code owner June 9, 2023 01:02
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @imcdo!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 877a7b1 into hashicorp:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

temporary_iam_instance_profile_policy_document doesn't use poller configs
3 participants