Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add working example for enabling metadata service v2 #429

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

nywilken
Copy link
Member

@nywilken nywilken commented Nov 3, 2023

  • Add working example for enabling metadata service v2
  • Update basic build to use non-deprecated ami
  • Add documentation for enabling instance metadata v2

Closes #357

@nywilken nywilken requested a review from a team as a code owner November 3, 2023 10:40
@nywilken nywilken added the documentation Improvements or additions to documentation label Nov 3, 2023
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for clarity I left a few comments regarding the imds_support attribute, since it enforces, and not enables IMDSv2 on the resulting AMI. By default (according to the AWS docs), both IMDSv1 and v2 are supported, but this attribute set to v2 forces the instances based on the AMI to only export metadata through IMDSv2.

Outside of that, LGTM

.web-docs/components/builder/ebs/README.md Outdated Show resolved Hide resolved
.web-docs/components/builder/ebs/README.md Outdated Show resolved Hide resolved
.web-docs/components/builder/ebs/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nywilken nywilken merged commit 5be7304 into main Nov 10, 2023
12 checks passed
@nywilken nywilken deleted the update/imdsv2-docs branch November 10, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EC2 Metadata Setting not working with latest packer version(1.8.6)
2 participants