Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update version.go #500

Merged

Conversation

tenthirtyam
Copy link
Contributor

Summary

  • Replaces the deprecated InitializePluginVersion with NewPluginVersion from packer-plugin-sdk, which is the recommended approach in version/version.go.
  • Removed superfluous comments that are already included in the SDK.

- Replaces the deprecated `InitializePluginVersion` with `NewPluginVersion` from `packer-plugin-sdk`, which is the recommended approach in `version/version.go`.
- Removed superfluous comments that are already included in the SDK.
@tenthirtyam tenthirtyam requested a review from a team as a code owner August 9, 2024 01:23
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tenthirtyam !

@lbajolet-hashicorp lbajolet-hashicorp merged commit 3dc75aa into hashicorp:main Aug 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants