Add support for setting public IP sku to ARM builder #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenGoldstrich
force-pushed
the
arm-public-ip-sku
branch
2 times, most recently
from
2d63be0 to
c2ae65d
Compare
JenGoldstrich
force-pushed
the
arm-public-ip-sku
branch
from
13c1610 to
70f4f50
Compare
nywilken
reviewed
May 21, 2024
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
JenGoldstrich
force-pushed
the
arm-public-ip-sku
branch
from
faf3ca5 to
0577b1c
Compare
|
@nywilken I have merged your changes, run make generate, and made public IP sku case insensitive for the user, lemme know what you think! |
…et, disallow setting sku when user provides their own network
nywilken
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a
public_ip_skuparameter, in March 2025 Microsoft is removing the ability to create Basic SKU public IP addresses, there are certain security aspects of this that do not really apply to the short lived IP that is created to connect to the build VM. Due to the many number of potential network configurations we want to release support for this early and encourage users to try out this functionality, so any unexpected bugs are caught long before the removal of basic IPs. This will minimize impact to our users.This PR also throws a new warning to inform users of the upcoming deprecation, and suggest they try this field
Closes #292