Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump packer plugin SDK from 0.5.2 to 0.5.4 #427

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Bump packer plugin SDK from 0.5.2 to 0.5.4 #427

merged 2 commits into from
Jun 20, 2024

Conversation

JenGoldstrich
Copy link
Contributor

Dependabot is failing and adding a 1.22 toolchain directive to the go.mod so I did this manually

go get github.com/hashicorp/packer-plugin-sdk
go mod tidy
packer-sdc fix .

packer-sdc fix produced no changes but it was reccomended to be run in this upgrade of the SDK.

@JenGoldstrich JenGoldstrich requested a review from a team as a code owner June 18, 2024 21:20
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit edf2fd2 into main Jun 20, 2024
12 checks passed
@lbajolet-hashicorp lbajolet-hashicorp deleted the bump_packer_plugin_sdk branch June 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Assignees
No one assigned
Labels
ignore-for-release tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JenGoldstrich @lbajolet-hashicorp