Remove x5t Header Check #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This check doesn't exist on the Terraform provider, and was added in the initial commit of this builder. It's a very old change that I do not think is required anymore An Azure employee reported that with entra minted tokens, this validation causes failures: #451
lbajolet-hashicorp
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Looking at the JWT spec quickly, it seems that you need to have a x5t or a kid for the JWT to be valid.
That said, the validation can be left as a responsibility to the Azure APIs, since they'll have to make sure the JWT is valid before accepting it, so I trust they do a better job at sticking to the specification than us.
In the end, LGTM over here, this'll likely accept more tokens, I'm not knowledgeable enough about JWTs to ensure that we don't too broadly accept those tokens, but I trust Azure will be the ones doing the validation on the token upstream so we should be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check exists from the days of old, and does not seem relevant anymore. When I search the Terraform AzureRM Provider for usages of the x5t header, the only references I see to it are in the now deprecated autorest library. in the go-azure-sdk it is only referenced by the Microsoft Graph package, which this plugin does not use, so this should be safe to remove.
Closes #451