Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance #96

Merged
merged 31 commits into from
May 4, 2024
Merged

Maintenance #96

merged 31 commits into from
May 4, 2024

Conversation

ksatirli
Copy link
Member

@ksatirli ksatirli commented Apr 23, 2024

Hello maintainers 👋🏼

This PR carries out some package maintenance and updates some of the examples.

I've also trimmed down dependencies in package.json and removed dependencies that are actually handled upstream in github-actions-core.

For testing purposes, I created an experimental tag, and used this here.

Conclusions:

  • Local execution is successful.
  • Self-test is successful
  • running the Action via GHA is successful.

Local execution test:

export RUNNER_TEMP=/tmp && export RUNNER_TOOL_CACHE=/tmp/ && node dist/index.js

Once approved, I'd like to release this as 3.1.0.

@ksatirli ksatirli marked this pull request as ready for review April 24, 2024 11:23
Copy link
Member

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicky comments on the latest stable version, but I'll leave it up to you to decide whether or not to address them. LGTM! 🚀

.github/workflows/actions-self-test.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
examples/packer.yml Show resolved Hide resolved
Copy link
Member

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@bschaatsbergen bschaatsbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@JenGoldstrich JenGoldstrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few thoughts!

package.json Outdated Show resolved Hide resolved
LICENSE Show resolved Hide resolved
test/hello-world.pkr.hcl Show resolved Hide resolved
@ksatirli ksatirli merged commit 60dc5f3 into main May 4, 2024
11 checks passed
@ksatirli ksatirli deleted the maintenance branch May 4, 2024 07:46
jooola referenced this pull request in hetznercloud/packer-plugin-hcloud May 6, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [hashicorp/setup-packer](https://togithub.com/hashicorp/setup-packer)
| action | minor | `v3.0.0` -> `v3.1.0` |

---

### Release Notes

<details>
<summary>hashicorp/setup-packer (hashicorp/setup-packer)</summary>

###
[`v3.1.0`](https://togithub.com/hashicorp/setup-packer/releases/tag/v3.1.0)

[Compare
Source](https://togithub.com/hashicorp/setup-packer/compare/v3.0.0...v3.1.0)

##### What's Changed

- Maintenance by [@&#8203;ksatirli](https://togithub.com/ksatirli) in
[https://github.com/hashicorp/setup-packer/pull/96](https://togithub.com/hashicorp/setup-packer/pull/96)
- Bump
[@&#8203;hashicorp/github-actions-core](https://togithub.com/hashicorp/github-actions-core)
from 1.0.0 to v1.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/hashicorp/setup-packer/pull/97](https://togithub.com/hashicorp/setup-packer/pull/97)
- Bump follow-redirects from 1.15.5 to 1.15.6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/hashicorp/setup-packer/pull/94](https://togithub.com/hashicorp/setup-packer/pull/94)

##### New Contributors

- [@&#8203;dependabot](https://togithub.com/dependabot) made their first
contribution in
[https://github.com/hashicorp/setup-packer/pull/97](https://togithub.com/hashicorp/setup-packer/pull/97)

**Full Changelog**:
hashicorp/setup-packer@v3.0.0...v3.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/hetznercloud/packer-plugin-hcloud).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants