Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v0.68.0 and the finalized/non preview management API, to be compatible with other consumers of the Azure SDK #161

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

sgmiller
Copy link
Contributor

@sgmiller sgmiller commented Sep 6, 2023

Overview

When updating other plugins that use the Azure SDK, we hit an
error as the Azure secrets engine imports a deprecated preview API.
This PR updates to the compatible Azure SDK and updates to the
nearest final API

… compatible with other consumers of the Azure SDK
@sgmiller sgmiller requested a review from a team September 6, 2023 17:27
@austingebauer
Copy link
Contributor

Acc tests passing after 2d29840:

$ make testacc
==> Checking that code complies with gofmt requirements...
go generate 
VAULT_ACC=1 go test -tags='vault-plugin-secrets-azure' $(go list ./... | grep -v /vendor/)  -timeout 45m
?       github.com/hashicorp/vault-plugin-secrets-azure/api     [no test files]
?       github.com/hashicorp/vault-plugin-secrets-azure/cmd/vault-plugin-secrets-azure  [no test files]
ok      github.com/hashicorp/vault-plugin-secrets-azure 96.990s

Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sgmiller sgmiller merged commit 569bc7a into main Sep 6, 2023
3 checks passed
@sgmiller sgmiller deleted the sgm/update-azure-sdk branch September 6, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants