Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle not found response when deleting app in wal rollback #220

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

fairclothjm
Copy link
Contributor

During the revoke call, Vault prints the below warning in operational logs:

secrets.azure.azure_1a4bd492: rollback error deleting App: err="autorest#WithErrorUnlessStatusCode: DELETE https://graph.microsoft.com/v1.0/directory/deletedItems/4ef6b566XXXXXXXXXa-1aa3a778abb7 failed with 404 Not Found: StatusCode=404"
secrets.azure.azure_1a4bd492: rollback error deleting App: err="autorest#WithErrorUnlessStatusCode: DELETE https://graph.microsoft.com/v1.0/directory/deletedItems/68f3cXXXXXXf-9b8c-7af3eef58b06 failed with 404 Not Found: StatusCode=404"

Previously, the delete call didn’t return 404 if the app isn’t found. However, we recently switched the underlying API.

@fairclothjm fairclothjm requested a review from a team September 9, 2024 17:32
@fairclothjm fairclothjm force-pushed the VAULT-28022/handle-404-delete-app branch from 44b9ab7 to 0e58415 Compare October 14, 2024 15:55
@fairclothjm fairclothjm merged commit b8b9497 into main Oct 14, 2024
4 checks passed
@fairclothjm fairclothjm deleted the VAULT-28022/handle-404-delete-app branch October 14, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants