Azure secret doc enhancement #23079
Merged
Azure secret doc enhancement #23079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
austingebauer
approved these changes
Sep 14, 2023
changelog/23079.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:improvement | |||
| secrets/azure: Added note that environment variables take precedence over API config. | |||
There was a problem hiding this comment.
I don't think we need a CL entry for docs changes. Typically only for product changes.
|
CI Results: |
|
Build Results: |
schavis
requested changes
Sep 14, 2023
changelog/23079.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:improvement | |||
| secrets/azure: Added note that environment variables take precedence over API config. | |||
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
schavis
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using environment variables over config provided explicitely through the API is counter-intuitve, which leads to wasted time figuring out why the provided configuration is not being used by Vault as expected.
Unfortunately changing this behavior would be a significant breaking change. As a short term mitigation solution we are adding a more explicit note in the documentaiton to help people avoid this pitfall.
Preview: