Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mfa login/totp #29094

Merged
merged 7 commits into from
Dec 13, 2024
Merged

mfa login/totp #29094

merged 7 commits into from
Dec 13, 2024

Conversation

mister-ken
Copy link
Contributor

@mister-ken mister-ken commented Dec 4, 2024

Description

🔍 Deploy preview

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@mister-ken mister-ken requested a review from a team as a code owner December 4, 2024 19:58
@mister-ken mister-ken self-assigned this Dec 4, 2024
@mister-ken mister-ken marked this pull request as draft December 4, 2024 19:59
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Dec 4, 2024

Build Results:
All builds succeeded! ✅

@mister-ken mister-ken changed the title initial commit mfa login/totp Dec 9, 2024
@mister-ken mister-ken marked this pull request as ready for review December 11, 2024 19:57
@mister-ken mister-ken merged commit 23a663f into main Dec 13, 2024
34 checks passed
@mister-ken mister-ken deleted the docs/mfa-login-totp branch December 13, 2024 15:38
Monkeychip pushed a commit that referenced this pull request Dec 18, 2024
* initial commit

* update mfa/totp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants