Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add Tune server performance documentation #29149

Merged
merged 8 commits into from
Dec 13, 2024

Conversation

brianshumate
Copy link
Member

@brianshumate brianshumate commented Dec 11, 2024

Description

Adds Tune server performance documentation for SPE-1010

🔍 Deploy preview

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@brianshumate brianshumate added pr/no-changelog pr/no-milestone hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed backport/1.18.x labels Dec 11, 2024
@brianshumate brianshumate self-assigned this Dec 11, 2024
@brianshumate brianshumate requested a review from a team as a code owner December 11, 2024 16:18
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

yhyakuna
yhyakuna previously approved these changes Dec 11, 2024
mister-ken
mister-ken previously approved these changes Dec 11, 2024
Copy link
Contributor

@mister-ken mister-ken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great doc, need to look closer later. Just a few suggestions, YMMV.

website/content/docs/concepts/tune-server-performance.mdx Outdated Show resolved Hide resolved
website/content/docs/concepts/tune-server-performance.mdx Outdated Show resolved Hide resolved
Co-authored-by: Ken Keller <104874953+mister-ken@users.noreply.github.com>
@brianshumate brianshumate dismissed stale reviews from mister-ken and yhyakuna via 3976ca6 December 11, 2024 18:50
@brianshumate brianshumate merged commit b4e3d3a into main Dec 13, 2024
34 checks passed
@brianshumate brianshumate deleted the docs/tune-server-performance branch December 13, 2024 13:34
Monkeychip pushed a commit that referenced this pull request Dec 18, 2024
* filename extension

* Update website/content/docs/concepts/tune-server-performance.mdx

Co-authored-by: Ken Keller <104874953+mister-ken@users.noreply.github.com>

* Update website/content/docs/concepts/tune-server-performance.mdx

Co-authored-by: Ken Keller <104874953+mister-ken@users.noreply.github.com>

---------

Co-authored-by: Ken Keller <104874953+mister-ken@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants