Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CE changes for vault-31750 #29303

Merged
merged 9 commits into from
Jan 9, 2025
Merged

CE changes for vault-31750 #29303

merged 9 commits into from
Jan 9, 2025

Conversation

raskchanky
Copy link
Contributor

@raskchanky raskchanky commented Jan 7, 2025

Description

These are the CE changes for https://github.com/hashicorp/vault-enterprise/pull/7120

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@raskchanky raskchanky requested a review from a team as a code owner January 7, 2025 00:47
@raskchanky raskchanky requested a review from tcrayford January 7, 2025 00:47
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 7, 2025
@raskchanky raskchanky added this to the 1.19.0-rc milestone Jan 7, 2025
@raskchanky raskchanky requested a review from a team as a code owner January 7, 2025 00:51
Copy link

github-actions bot commented Jan 7, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jan 7, 2025

Build Results:
All builds succeeded! ✅

@raskchanky raskchanky requested review from miagilepner and removed request for tcrayford January 7, 2025 01:37
physical/raft/raft.go Outdated Show resolved Hide resolved
@raskchanky raskchanky requested a review from miagilepner January 7, 2025 17:24
Copy link
Contributor

@miagilepner miagilepner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of tiny nit suggestions, but otherwise good!

changelog/29303.txt Outdated Show resolved Hide resolved
physical/raft/raft_autopilot.go Outdated Show resolved Hide resolved
@raskchanky raskchanky requested a review from miagilepner January 8, 2025 18:33
miagilepner
miagilepner previously approved these changes Jan 9, 2025
Copy link
Contributor

@miagilepner miagilepner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@raskchanky raskchanky merged commit f625f50 into main Jan 9, 2025
92 checks passed
@raskchanky raskchanky deleted the vault-31750-ce branch January 9, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants