Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of sdk/db: do not hold the lock on Close into release/1.18.x #29333

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #29097 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

The below text is copied from the body of the original PR.


Description

This fixes a bug between the Vault grpc client and the plugin grpc server. This is related to slow database session End calls which could be slow network or database limits. When we see a slow Database session close, this is enough for goroutines to be blocked and prevent a new database config from being created due to an internal timeout on the plugin in the Type() call. This produces the following error in Vault:

error creating database object: invalid database version: 2 errors occurred: 
  * error getting plugin type: unable to get database plugin type: rpc error: code = DeadlineExceeded desc = context deadline exceeded
  * Incompatible API version with plugin. Plugin version: 5, Client versions: [3 4]

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/sdk/db/close-non-locking/personally-free-walleye branch from 8d57f60 to d3e4087 Compare January 9, 2025 20:42
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 9, 2025
@fairclothjm fairclothjm enabled auto-merge (squash) January 9, 2025 20:45
Copy link

github-actions bot commented Jan 9, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jan 9, 2025

Build Results:
All builds succeeded! ✅

@fairclothjm fairclothjm merged commit 3c34663 into release/1.18.x Jan 9, 2025
81 of 83 checks passed
@fairclothjm fairclothjm deleted the backport/sdk/db/close-non-locking/personally-free-walleye branch January 9, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants