UI - no jquery #6768
Merged
UI - no jquery #6768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaley
previously approved these changes
May 21, 2019
…ge-object - it actually triggers jquery usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a previous failed PR to remove jQuery, I looked at this again and came across ember-cli/ember-fetch#204 - it turns out that including
preferNative:truein theember-fetchconfig fixes the flickering of the tests.Additionally after doing that it surfaced a lot of Ember Data errors akin to the one in this issue: emberjs/data#5387 and as noted in this comment: emberjs/data#5387 (comment) and the linked repo that fixes the issue https://github.com/efx/-ember-data-cannot-update-watchers/commit/b5c0a0248f358514bab68f7f73ba59ed094449c9#diff-abef98b98958054d1769915c9b057f3bR14, it's important to unset a model on a controller when you unload it. That's not something we were doing previously, and we are using the
unload-model-routemixin pretty liberally through the application, doing this cleaned up all of the errors that we saw.