Chore: update extensions list #1677
Conversation
| @@ -121,8 +121,8 @@ library | |||
| , ConstraintKinds | |||
| , DataKinds | |||
| , DeriveDataTypeable | |||
| , DeriveFunctor | |||
There was a problem hiding this comment.
Why did this need to get turned on?
There was a problem hiding this comment.
We don't actually need it here. But I thought I'd stay consistent with the other extensions in other-extensions: if the extensions is enabled in some source file, not in Haskell2010 and not "protected" by CPP, then list it here.
Is there a different logic for listing them here?
There was a problem hiding this comment.
I don't think there is really any system to the extensions enabled. I think it would be best to fix the failing query string test on master first. But I do think this looks sensible. Is TypeFamilyDependencies added for the same reason?
There was a problem hiding this comment.
Yes. This one is explicitly enabled for servant/src/Servant/API/ResponseHeaders.hs.
This PR:
servant.cabalfile (should fix Check other-extensions field #1202).