pick up PR for named routes cookbook again #1726
Conversation
|
Thank you very much @MangoIV for this work! Reading the PR content, I feel like we ought to merge the NamedRoutes and Generics cookbooks together, under the NamedRoutes name. |
|
that's a good idea, I will do that then :) |
|
@MangoIV Are you still planning to do this? |
|
I am. I think we’re blocked by servant-qc (release, I have updated it) but I don’t know, let me check; will get to it this week perhaps ;) |
|
@MangoIV You may rebase your PR on top of |
|
Lovely thank you <3 |
MangoIV
force-pushed
the
inserting_doc_NamedRoutes
branch
3 times, most recently
from
a97a630 to
bc22eaf
Compare
|
Any news/blockers here regarding the merge? I also find this very valuable. |
|
@tfc yes, Mango still has to merge the two cookbooks. :) |
MangoIV
force-pushed
the
inserting_doc_NamedRoutes
branch
2 times, most recently
from
2ac385d to
2a52a01
Compare
|
I have basically dropped the entire generic cookbook in favour of named routes, afaict I have transported all the information that didn't already occur in named routes but I would appreciate a thorough review to confirm. |
MangoIV
force-pushed
the
inserting_doc_NamedRoutes
branch
2 times, most recently
from
e90ea2b to
28cdfb6
Compare
MangoIV
force-pushed
the
inserting_doc_NamedRoutes
branch
from
28cdfb6 to
f2e3089
Compare
MangoIV
force-pushed
the
inserting_doc_NamedRoutes
branch
from
f2e3089 to
812dcf4
Compare
| , title :: Title | ||
| , year :: Year | ||
| } | ||
| deriving stock Generic |
There was a problem hiding this comment.
Hmm, how come you didn't have to enable DerivingStrategies? It's not part of GHC2021.
| , wai >=3.2 | ||
| , warp >=3.2 | ||
|
|
||
| default-language: Haskell2010 |
There was a problem hiding this comment.
Wouldn't it be simpler to just declare GHC2021 here?
| maintainer: haskell-servant-maintainers@googlegroups.com | ||
| build-type: Simple | ||
| cabal-version: >=1.10 | ||
| tested-with: GHC ==8.6.5 || ==8.8.3 || ==8.10.1 |
There was a problem hiding this comment.
This can't be right, since it's using GHC2021.
|
@ysangkok i still have a couple of failures sorry, I should mark it as draft again |
This PR is supposed to pick up the great work started in #1542 and rebase on current changes as well as apply fixes suggested by the reviewers, potentially also addressing new change requests.