Integrate MultiVerb into the servant packages
#1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theophile-scrive
force-pushed
the
integrate-multiverb
branch
3 times, most recently
from
b476b8f to
84ccbd0
Compare
theophile-scrive
changed the title
servant packageservant package
theophile-scrive
changed the title
servant packageservant packages
theophile-scrive
force-pushed
the
integrate-multiverb
branch
from
ff04313 to
9e0d8d2
Compare
theophile-scrive
force-pushed
the
integrate-multiverb
branch
6 times, most recently
from
d10fc87 to
4ecb4ec
Compare
theophile-scrive
force-pushed
the
integrate-multiverb
branch
2 times, most recently
from
b7e31f0 to
77d471f
Compare
fisx
reviewed
Aug 27, 2024
theophile-scrive
force-pushed
the
integrate-multiverb
branch
2 times, most recently
from
a61130b to
046d35f
Compare
fisx
reviewed
Aug 29, 2024
theophile-scrive
force-pushed
the
integrate-multiverb
branch
11 times, most recently
from
8be000f to
1a6b30d
Compare
theophile-scrive
force-pushed
the
integrate-multiverb
branch
2 times, most recently
from
9e43f6e to
9835857
Compare
fisx
reviewed
Aug 30, 2024
theophile-scrive
force-pushed
the
integrate-multiverb
branch
2 times, most recently
from
6d3234e to
3a84e18
Compare
fisx
reviewed
Sep 17, 2024
fisx
reviewed
Sep 22, 2024
There was a problem hiding this comment.
Sorry for the lag, but I think we're getting there!
Could you go through the unresolved comments one more time and confirm that you're ok with resolving all of them?
If so I'll approve this PR.
After that: @arianvp wanna give it a read, and maybe merge? @pcapriotti as the author of this code, do you have any feedback?
theophile-scrive
force-pushed
the
integrate-multiverb
branch
from
57e5a38 to
e70eaec
Compare
arianvp
reviewed
Sep 23, 2024
theophile-scrive
force-pushed
the
integrate-multiverb
branch
from
e70eaec to
c52bd5c
Compare
|
@pcapriotti @fisx I'd love your final feedback on this. :) |
jkarni
reviewed
Dec 5, 2024
servant-client-core/src/Servant/Client/Core/ResponseUnrender.hs
Outdated
Show resolved
Hide resolved
| -- | ||
| -- Similar to 'Respond', but hardcodes the content type to be used for | ||
| -- generating the response. | ||
| data RespondAs ct (s :: Nat) (description :: Symbol) (a :: Type) |
There was a problem hiding this comment.
It feels a bit sad that there are two locations where a content-type may be specified, and they can be conflicting. It's not obvious to me what:
type Responses = '[ RespondAs 'HTML 200 "blah" Int ]
type API = MultiVerb 'GET '[JSON] Responses Result
Means, and why I should be allowed to say this.
Is there any reason to have this besides RespondEmpty? If not, maybe RespondEmpty can be it's own datatype?
There was a problem hiding this comment.
Good call. @pcapriotti @fisx I'd like your input on this.
fisx
approved these changes
Dec 8, 2024
This commit is Part 1 of the integration, where only the `servant`Epackage is touched. `Verb` is redefined as an alias for `MultiVerb1` inEorder to make the transition transparent to users of `Verb`.
theophile-scrive
force-pushed
the
integrate-multiverb
branch
from
c52bd5c to
86b0f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is Part 1 of the integration, where only the packages of this monorepo are touched.
MultiVerbis integrated alongside of the other Verb machinery, so that people may take their time to transition to it.IsWaiBody will not be able to live in its current form, as it mixes concepts from the Server and Client packages.
This impacts SomeResponse, which itself impacts the HasClient and HasServer instances.
ResponseF can be replicated internally, even without the httpVersion field.
SomeResponse can be kept on the server, but the client can move to use ResponseF.
The
IsResponseandIsResponseListclasses are split between client-sideReponse{,List}Unrenderand server-sideResponse{,List}Render.This is a collaborative work between Scrive AB and Wire Swiss GmbH.