Convert display functions into Pretty instances
#10526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekosaur
approved these changes
Nov 4, 2024
grayjay
reviewed
Nov 20, 2024
cabal-install-solver/src/Distribution/Solver/Types/ConstraintSource.hs
Outdated
Show resolved
Hide resolved
cabal-install-solver/src/Distribution/Solver/Types/ConstraintSource.hs
Outdated
Show resolved
Hide resolved
cabal-install-solver/src/Distribution/Solver/Types/PackageConstraint.hs
Outdated
Show resolved
Hide resolved
|
@9999years Why did you close this PR? I liked that it reduced the size of #10524, and I thought that it was a great cleanup on its own. |
|
@grayjay Oh okay, I thought it wasn't significant enough to be worth the effort, but i can fix it up. |
9999years
force-pushed
the
pretty-pretty
branch
2 times, most recently
from
fa7fa8b to
9f199e7
Compare
mergify
bot
added
ready and waiting
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
Needs manual rebase and |
We have a lot of `showType` functions that are effectively a `Pretty` instance but less composable. Let's make them proper `Pretty` instances. Split off of haskell#10524
9999years
force-pushed
the
pretty-pretty
branch
from
9f199e7 to
e20c10c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of
showTypefunctions that are effectively aPrettyinstance but less composable. Let's make them properPrettyinstances.Split off of #10524