Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pure-Haskell replacement for is_ascii.c #545

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Add pure-Haskell replacement for is_ascii.c #545

merged 5 commits into from
Jan 30, 2024

Conversation

chreekat
Copy link
Contributor

wip. Will add some comments inline.

chreekat
chreekat commented Nov 10, 2023
View reviewed changes
Copy link
Contributor Author

@chreekat chreekat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the impacted exported functions are decodeLatin1 and isAscii. [edit] And decodeASCIIPrefix, which depends on asciiPrefixLength

src/Data/Text/Encoding.hs Show resolved Hide resolved
src/Data/Text/Internal/IsAscii.hs Outdated Show resolved Hide resolved
src/Data/Text/Internal/IsAscii.hs Outdated Show resolved Hide resolved
text.cabal Outdated Show resolved Hide resolved
@Bodigrim
Copy link
Contributor

@chreekat @hsyl20 are we looking to finish this up in time for GHC 9.10 (which is soon)?

@chreekat
Copy link
Contributor Author

@Bodigrim for me at least, this is just a free-time activity, and I haven't had a lot of that lately. I know @hsyl20 's team has been working an a pure-Haskell bytestring that they want to get finished for 9.10, but not sure about text.

@hsyl20
Copy link
Contributor

hsyl20 commented Jan 25, 2024

Nothing started about text afaik. So it's likely that it won't be done in time for 9.10

chreekat
chreekat commented Jan 26, 2024
View reviewed changes
text.cabal Show resolved Hide resolved
@chreekat
Copy link
Contributor Author

Plot twist: I had some extra time today.

@chreekat chreekat marked this pull request as ready for review January 26, 2024 19:38
@chreekat
Copy link
Contributor Author

chreekat commented Jan 26, 2024 •
edited
Loading

Oops, bad rebase. Will fix tomorrow.

@chreekat
Copy link
Contributor Author

This is ready for review now.

@chreekat chreekat mentioned this pull request Jan 27, 2024
Merged
Bodigrim
Bodigrim reviewed Jan 27, 2024
View reviewed changes
text.cabal Outdated Show resolved Hide resolved
@Bodigrim Bodigrim requested a review from Lysxia January 28, 2024 12:16
@hsyl20
Copy link
Contributor

hsyl20 commented Jan 30, 2024

Thanks for doing this @chreekat!

@Bodigrim Bodigrim merged commit 8caff61 into haskell:master Jan 30, 2024
27 checks passed
@Bodigrim
Copy link
Contributor

Thanks!

@chreekat chreekat deleted the b/pure-is_ascii branch January 31, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lysxia Lysxia Lysxia approved these changes

@Bodigrim Bodigrim Bodigrim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chreekat @Bodigrim @hsyl20 @Lysxia