Added file write benchmarks #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
reviewed
Apr 23, 2024
BebeSparkelSparkel
force-pushed
the
filewrite-bench
branch
from
c82fe10 to
7f6adda
Compare
BebeSparkelSparkel
force-pushed
the
filewrite-bench
branch
from
7f6adda to
43e6883
Compare
Bodigrim
reviewed
Apr 28, 2024
Bodigrim
approved these changes
Apr 30, 2024
|
Need to add tests for lazy bytestring will small chunk size. Not finished yet. |
Lysxia
reviewed
May 2, 2024
|
@Lysxia good to go? |
Lysxia
approved these changes
May 6, 2024
There was a problem hiding this comment.
Yes this is good to go.
I was just confused about how to interpret the results to justify an optimization to putStr in PR #589. See this thread on an earlier version of it).
But these benchmarks are still useful in general to keep track of performance improvements to printing Text.
|
Thanks @BebeSparkelSparkel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #446