-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve test function write_read #593
Merged
Bodigrim
merged 7 commits into
haskell:master
from
BebeSparkelSparkel:improve-write_read
May 19, 2024
Merged
improve test function write_read #593
Bodigrim
merged 7 commits into
haskell:master
from
BebeSparkelSparkel:improve-write_read
May 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bodigrim
reviewed
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on improving the test suite!
Bodigrim
approved these changes
May 8, 2024
Lysxia
reviewed
May 14, 2024
Lysxia
reviewed
May 14, 2024
Lysxia
reviewed
May 15, 2024
Lysxia
reviewed
May 16, 2024
Lysxia
approved these changes
May 16, 2024
@BebeSparkelSparkel this is unrelated to your work here, but could you please allow |
@BebeSparkelSparkel thanks a ton! Please rebase this PR. |
Now tests different encodings not just UTF8. Removed NFData constraint so that Builder can be tested.
BebeSparkelSparkel
force-pushed
the
improve-write_read
branch
from
May 19, 2024 12:11
e501102
to
b1d29f0
Compare
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now tests different encodings not just UTF8.
Removed NFData constraint so that Builder can be tested.
Should be pulled before hPutStr and hPutBuilder PRs