-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies (support ghc 9.12) #624
base: master
Are you sure you want to change the base?
Conversation
It is, for quite a while. |
I was incorrectly using |
ef11d47
to
42d1aa9
Compare
.github/workflows/haskell-ci.yml
Outdated
- compiler: ghc-9.12.0.20241114 | ||
compilerKind: ghc | ||
compilerVersion: 9.12.0.20241114 | ||
setup-method: ghcup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is due
ghcup-jobs: >=8.2
in cabal.haskell-ci
. haskell-ci
tries to use the default ghcup channel for 9.12 versions too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That configuration field should be removed. It's more harmful than useful.
d8494b0
to
ea1a42e
Compare
I raised https://gitlab.haskell.org/ghc/ghc/-/issues/25548 to clarify whether bumping |
cabal.project
Outdated
|
||
allow-newer: | ||
, splitmix:base | ||
, tasty-inspection-testing:base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep cabal.project
unchanged please: these allow-newer
tend to fossilize and then no one remembers which version of GHC they are for. Besides, tasty-inspection-testing
has been bumped already and I imagine splitmix
will follow the suite soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the allowed-newer
for tasty-inspection-testing
and bracketed it with if impl (ghc >= 9.12)
@erikd may I ask you to update it once more? Please use the latest |
ghc-9.12
is not yet available in CI.