Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLIENTS: Add PATCH methods #135

Closed
wants to merge 2 commits into from
Closed

CLIENTS: Add PATCH methods #135

wants to merge 2 commits into from

Conversation

diogod3
Copy link

@diogod3 diogod3 commented May 16, 2023

Closes #134

cjdutoit
cjdutoit requested changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@cjdutoit cjdutoit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IRESTFulApiFactoryClient and IRESTFulApiClient not in sync, but other than that LGTM

@diogod3
Copy link
Author

diogod3 commented May 17, 2023

Thanks @cjdutoit

I used the PUT methods as a guideline and that method was missing from the interface, but it was present in the implementation 😅 I added it for both PUT and PATCH.

@diogod3 diogod3 requested a review from cjdutoit May 17, 2023 08:27
@SlimAhmad
Copy link

@cjdutoit would this be merged anytime soon, i'll like to make use of the patch method in my library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdutoit cjdutoit Awaiting requested review from cjdutoit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLIENTS: Add PATCH methods
4 participants
@diogod3 @SlimAhmad @cjdutoit @hassanhabib