Library upgrade to version V2.10.1 #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassanhabib
reviewed
Jun 7, 2024
| // then | ||
| unauthorizedObjectResult.Should() | ||
| .BeEquivalentTo(expectedUnauthorizedObjectResult); | ||
| } |
There was a problem hiding this comment.
Maybe got deleted by mistake. I've updated again. Will be see in the next revision once I push.
hassanhabib
reviewed
Jun 7, 2024
Comment on lines
82
to
85
| // Type exception: FormServiceException | ||
| // INNER Exception: FailedFormServiceException | ||
|
|
||
| // Current Inner Exception: SYSTEM.EXCEPTION |
There was a problem hiding this comment.
No comments except for // given, // when and // then
hassanhabib
reviewed
Jun 7, 2024
| innerException: innerException) | ||
| { } | ||
|
|
||
|
|
hassanhabib
reviewed
Jun 7, 2024
| @@ -23,74 +23,84 @@ internal partial class FormCoordinationService | |||
| } | |||
| catch (Models.Coordinations.Forms.Exceptions.NullObjectException nullObjectException) | |||
| { | |||
| var message = "Form coordination validation errors occurred, please try again."; | |||
| var formCoordinationValidationException = | |||
hassanhabib
reviewed
Jun 7, 2024
| var formServiceException = new FormServiceException(failedFormServiceException); | ||
| var formServiceException = new FormServiceException( | ||
| message: "Form service error occurred, contact support.", | ||
|
|
hassanhabib
reviewed
Jun 7, 2024
Comment on lines
62
to
64
| new FailedTypeDependencyValidationException( | ||
| message: "Failed type dependency validation error occurred, fix errors and try again.", | ||
| innerException: exception); |
ecemozgoncu
commented
Jun 10, 2024
hassanhabib
reviewed
Jun 10, 2024
| @@ -23,74 +23,94 @@ internal partial class FormCoordinationService | |||
| } | |||
| catch (Models.Coordinations.Forms.Exceptions.NullObjectException nullObjectException) | |||
| { | |||
|
|
|||
| var message = "Form coordination validation errors occurred, please try again."; | |||
There was a problem hiding this comment.
Whern the right side of the equation in any code is not explicit about the type for instance new String() you must explicitly specify the type on the left side.
In this case here, it would be string message not var message
Read more here in the C# Coding Standard:
https://github.com/hassanhabib/CSharpCodingStandard
hassanhabib
reviewed
Jun 10, 2024
|
|
||
| throw formCoordinationDependencyException; | ||
| } | ||
| catch (Exception exception) | ||
| { | ||
|
|
There was a problem hiding this comment.
No empty lines between one-liners except for return statements
hassanhabib
reviewed
Jun 10, 2024
| var typeValidationException = new TypeValidationException(nullObjectException); | ||
| var typeValidationException = new TypeValidationException( | ||
| message: "Type validation errors occurred, fix errors and try again.", | ||
| innerException: nullObjectException); |
hassanhabib
reviewed
Jun 10, 2024
| @@ -21,7 +21,9 @@ private static void ValidatePropertyModelIsNotNull(PropertyModel propertyModel) | |||
| if (propertyModel is null) | |||
| { | |||
| var argumentNullException = new ArgumentNullException(nameof(propertyModel)); | |||
| var nullPropertyModelException = new NullPropertyModelException(argumentNullException); | |||
| var nullPropertyModelException = new NullPropertyModelException( | |||
hassanhabib
reviewed
Jun 10, 2024
| @@ -114,7 +114,7 @@ public partial class FormOrchestrationServiceTests | |||
|
|
|||
| var expectedFormOrchestrationDependencyException = | |||
| new FormOrchestrationDependencyException( | |||
| message: "Form orchestration dependency error occurred, fix errors and try again.", | |||
| message: "Form orchestration dependency validation error occurred, fix the errors and try again.", | |||
| innerException: dependancyException); | |||
There was a problem hiding this comment.
parameters stay at the same level of indentation
ecemozgoncu
commented
Jun 10, 2024
glhays
reviewed
Jul 17, 2024
|
|
||
| throw formCoordinationValidationException; | ||
| } | ||
| catch (FormOrchestrationValidationException formOrchestrationValidationException) | ||
| { | ||
| string message = "Form coordination dependency validation error occurred, fix the errors and try again."; |
There was a problem hiding this comment.
Suggested change
| string message = "Form coordination dependency validation error occurred, fix the errors and try again."; | |
| string message = "Form coordination dependency validation error occurred, fix the errors and try again."; | |
| var formCoordinationDependencyValidationException = | |
| new FormCoordinationDependencyValidationException(message, formOrchestrationValidationException); |
There was a problem hiding this comment.
@ecemozgoncu example of what's needed to resolve comments in this file. Line break between single and multi-liners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.