Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Alpine 3.21 (NodeJS 22) #2015

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Update to Alpine 3.21 (NodeJS 22) #2015

merged 1 commit into from
Jan 4, 2025

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 4, 2025

Proposed Changes

An attempt to update to the latest NodeJS by replacing the base image to Alpine 3.21.

Hopefully arm builds will now go through Docker buildx this time. The upstream QEMU issue has been closed (although Docker QEMU doesn't use the latest yet).

../Frenck

Summary by CodeRabbit

  • Dependency Updates

    • Updated Renovate configuration to use Alpine Linux version 3.21
    • Updated Node-RED Dockerfile with newer base image and package versions
    • Updated build configuration for Node-RED with new base image for aarch64 and amd64 architectures
  • Package Version Upgrades

    • Upgraded linux-headers, py3-pip, python3-dev
    • Updated git, icu-data-full, nginx, openssh-client
    • Added nodejs and npm packages

Copy link

coderabbitai bot commented Jan 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request involves updating dependencies and base images for the Node-RED project. The changes span across three files: .github/renovate.json, node-red/Dockerfile, and node-red/build.yaml. The primary modifications include updating the Alpine Linux image version, changing the base Docker image, and upgrading various package versions such as linux-headers, python packages, git, nginx, nodejs, and openssh-client.

Changes

File Change Summary
.github/renovate.json Updated Alpine Linux image version from 3_19 to 3_21 in depNameTemplate
node-red/Dockerfile - Changed base image from base-nodejs:0.2.5 to base:17.0.2
- Updated multiple package versions (linux-headers, py3-pip, python3-dev, git, etc.)
- Added nodejs and npm packages
node-red/build.yaml Updated base images for aarch64 and amd64 from base-nodejs:0.2.5 to base:17.0.2

Possibly related issues

  • Dependency Dashboard #1577 (Dependency Dashboard): This issue tracks dependency updates, which aligns with the current PR's focus on updating package and base image versions.

Possibly related PRs

Suggested labels

breaking-change

Poem

🐰 Hop, hop, dependencies dance,
Versions leap with each new chance,
Base images shift like morning dew,
Node-RED's update, fresh and true!
Renovate's magic makes code shine bright 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74a8029 and 6e850e6.

📒 Files selected for processing (3)
  • .github/renovate.json (1 hunks)
  • node-red/Dockerfile (2 hunks)
  • node-red/build.yaml (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@frenck frenck added dependencies Upgrade or downgrade of project dependencies. major This PR causes a major version bump in the version number. labels Jan 4, 2025
@frenck frenck marked this pull request as ready for review January 4, 2025 17:38
@frenck frenck merged commit e431479 into main Jan 4, 2025
19 checks passed
@frenck frenck deleted the frenck-2025-0025 branch January 4, 2025 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies. major This PR causes a major version bump in the version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant