Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configuration: skip unknown metric types #21

Merged
merged 2 commits into from
Oct 8, 2024
Merged

configuration: skip unknown metric types #21

merged 2 commits into from
Oct 8, 2024

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Oct 8, 2024 •
edited
Loading

  • Skip unknown metric types to avoid duplication.
  • Improve introspection performance with concurrency

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-prometheus/connector/api 62% ➖
github.com/hasura/ndc-prometheus/connector/client 58% ➖
github.com/hasura/ndc-prometheus/connector 59% ➖
github.com/hasura/ndc-prometheus/connector/internal 47% ➖
github.com/hasura/ndc-prometheus/connector/metadata 90% ✔
github.com/hasura/ndc-prometheus/connector/types 100% ✔
Summary 62% (2071 / 3362) ➖

Minimum allowed line rate is 40%

@hgiasac hgiasac merged commit 1a00a73 into main Oct 8, 2024
1 check passed
@hgiasac hgiasac deleted the skip-unknown-metrics branch October 8, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hgiasac