Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to v17 #1348

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

upgrade to v17 #1348

wants to merge 1 commit into from

Conversation

yaacovCR
Copy link

with canary-pr-4288

with canary-pr-4288
Copy link

vercel bot commented Nov 15, 2024

@yaacovCR is attempting to deploy a commit to the Michael Hayes' projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: 7248227

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yaacovCR
Copy link
Author

proof of concept, see: graphql/graphql-js#4288 (comment)

besides the caveats mentioned there, this version of the upgrade does not preserve backwards compatibility

not sure you will find this helpful, but putting it out there (rather than just deleting after my experimentation) just in case

side-note: this project is amazing!

@hayes
Copy link
Owner

hayes commented Nov 15, 2024

thanks for sharing this! This will be really useful

I think this will end up needing to be a major release to handle the defaultValue changes properly

@yaacovCR
Copy link
Author

I think this will end up needing to be a major release to handle the defaultValue changes properly

This comment inspired graphql/graphql-js#4296 -- not 100% sure, but I wonder if that means that the upgrade to v17 no longer has to be breaking (at least for this library).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants