fix(exchange): unneeded string

src/exchange/engines/currencyapi/exchange.go

@@ -25,7 +25,7 @@ func (e Exchange) Exchange(base currency.Currency) (currency.Currencies, error)
  }
 
  // Unmarshal the response.
- dataRates, err := extractRatesFromResp(string(body), base)
+ dataRates, err := e.extractRates(string(body), base)
  if err != nil {
  return nil, fmt.Errorf("failed to extract rates from response: %w", err)
  }

src/exchange/engines/currencyapi/json.go

@@ -10,7 +10,7 @@ import (
 )
 
 // Rates field is named the same as base currency.
-func extractRatesFromResp(resp string, base currency.Currency) (map[string]float64, error) {
+func (e Exchange) extractRates(resp string, base currency.Currency) (map[string]float64, error) {
  pattern := `"` + base.Lower() + `":\s*{[^}]*}`
  regexp := regexp.MustCompile(pattern)
  match := regexp.FindString(resp)

src/exchange/engines/currencyapi/new.go

@@ -4,14 +4,12 @@ import (
  "github.com/hearchco/agent/src/exchange/currency"
 )
 
-type Exchange struct {
- apiUrl string
-}
+type Exchange struct{}
 
 func New() Exchange {
- return Exchange{apiUrl}
+ return Exchange{}
 }
 
 func (e Exchange) apiUrlWithBaseCurrency(base currency.Currency) string {
- return e.apiUrl + "/" + base.Lower() + ".json"
+ return apiUrl + "/" + base.Lower() + ".json"
 }

src/exchange/engines/exchangerateapi/new.go

@@ -4,14 +4,12 @@ import (
  "github.com/hearchco/agent/src/exchange/currency"
 )
 
-type Exchange struct {
- apiUrl string
-}
+type Exchange struct{}
 
 func New() Exchange {
- return Exchange{apiUrl}
+ return Exchange{}
 }
 
 func (e Exchange) apiUrlWithBaseCurrency(base currency.Currency) string {
- return e.apiUrl + "/" + base.String()
+ return apiUrl + "/" + base.String()
 }

src/exchange/engines/frankfurter/new.go

@@ -4,12 +4,10 @@ import (
  "github.com/hearchco/agent/src/exchange/currency"
 )
 
-type Exchange struct {
- apiUrl string
-}
+type Exchange struct{}
 
 func New() Exchange {
- return Exchange{apiUrl}
+ return Exchange{}
 }
 
 func (e Exchange) apiUrlWithBaseCurrency(base currency.Currency) string {