Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HED-SCORE version 2.0.0 prerelease #158

Closed
wants to merge 29 commits into from
Closed

HED-SCORE version 2.0.0 prerelease #158

wants to merge 29 commits into from

Conversation

dorahermes
Copy link
Member

This is a major revision of the HED-SCORE schema library with several non-backwards compatible changes. Several major updates include:

  • Citations are added for all definitions.
  • Source localization and brain region tags have been removed. Several simple tags from HED can be used to indicate body parts and other tools and atlases can provide more detail for brain regions.
  • Overlapping tags with HED (e.g. drowsiness) have been removed, and replaced with suggested tags (drowsy). For example, asymmetries and sides (left/right) should be tagged with HED tags for left/right/symmetrical/asymmetrical. These tags are included as suggested tags.

…al and frontal arousal pattern to correct section under physiological patterns (Table 14)
…zure, renamed electrographic seizure to electroencephalographic seizure, moved cataplexy to sleep related episodes and moved unclassified epileptic seizure to udner unknown onset seizure per 2017 supplement 1
…chaged numerical/takes value. Still need to revisit muscle side after going over finding properties/hemi.
…and some changes throughout for suggestedTags, replacing positive and negative and symmetric etc with suggestedTags
@dorahermes
Copy link
Member Author

@VisLab @neuromechanist @smakeig @christinerogers please review - this is open for comments!

@dorahermes
Copy link
Member Author

Question: is it possible to have a top-level tag can have a free text or have a child. I think this is incorrect, but not sure how to fix:

** Provocative-factor <nowiki>{SuggestedTag=Hyperventilation}[Provocative factors are defined as transient and sporadic endogenous or exogenous elements capable of evoking/triggering seizures immediately following the exposure to it. (Source: Beniczky ea 2013.)]</nowiki>
    *** <nowiki># {takesValue, valueClass=textClass}[Free text.]</nowiki>
    *** Reflex-provoked
          **** <nowiki># {takesValue, valueClass=textClass}[Free text.]</nowiki>

** Tonic-contraction <nowiki> [Source: Beniczky ea 2017, Table 16.] </nowiki>
** Other-EMG-features <nowiki> {requireChild} [Source: Beniczky ea 2017, Table 16.]</nowiki>
*** <nowiki># {takesValue, valueClass=textClass}[Free text.]</nowiki>
* Other-polygraphic-channel <nowiki> {requireChild}[Source: Beniczky ea 2017, Section 13.] </nowiki>
** <nowiki># {takesValue, valueClass=textClass}[Free text.]</nowiki>


'''Finding-property''' <nowiki>[Descriptive element similar to main HED /Property. Something that pertains to a thing. A characteristic of some entity. A quality or feature regarded as a characteristic or inherent part of someone or something. HED attributes are adjectives or adverbs.]</nowiki>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might think about the name of this... after we see how things fit in 8.3.0.

* Source-analysis-property <nowiki>[In case source imaging is done, the results are scored at sublobar level: frontal (perisylvian-superior surface; lateral; mesial; polar; orbitofrontal), temporal (polar; basal, lateral-anterior; lateral-posterior; perisylvian-inferior surface), central (lateral convexity; mesial; central sulcus – anterior surface, central sulcus – posterior surface; opercular), parietal (lateral-convexity; mesial; opercular), occipital (lateral; mesial, basal) and insula. (Source: Beniczky ea 2017, Section 8.)]</nowiki>
** <nowiki># {takesValue, valueClass=textClass}[Free text.]</nowiki>

* Location-property <nowiki>{suggestedTag=Left, suggestedTag=Right, suggestedTag=Body-part}[Location can be scored for findings. Semiologic finding can also be characterized by the somatotopic modifier (i.e. the part of the body where it occurs). In this respect, laterality (left, right, symmetric, asymmetric, left greater than right, right greater than left), body part (eyelid, face, arm, leg, trunk, visceral, left/right) and centricity (axial (trunk), proximal limb, distal limb). (Source: Beniczky ea 2017, Sections 8 and 10)]</nowiki>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is important! --

@VisLab
Copy link
Member

VisLab commented Apr 8, 2024

Question: is it possible to have a top-level tag can have a free text or have a child. I think this is incorrect, but not sure how to fix:

** Provocative-factor <nowiki>{SuggestedTag=Hyperventilation}[Provocative factors are defined as transient and sporadic endogenous or exogenous elements capable of evoking/triggering seizures immediately following the exposure to it. (Source: Beniczky ea 2013.)]</nowiki>
    *** <nowiki># {takesValue, valueClass=textClass}[Free text.]</nowiki>
    *** Reflex-provoked
          **** <nowiki># {takesValue, valueClass=textClass}[Free text.]</nowiki>

A # node cannot have a sibling. Therefore this would be okay if Reflex-provoked weren't there. The solution is to add a node that is a sibling of Reflex-provoked: Other-provocative-factor under Provocative-factor that has the # child and is used for the text description. Otherwise you can suggest a tag for a description to be used with Provocative-factor.

@dorahermes dorahermes closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants