Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anatomy reorganization #174

Merged
merged 14 commits into from
May 3, 2024
Merged

Conversation

neuromechanist
Copy link
Member

Following the attempted PR #167 and issue #164, this current PR includes the changes in the hierarchy under the latest Schema 8.3.0.

The HED IDs are set to 0000000 to pass the validators. The MediaWiki and XML passed Validator and the difference between 8.3.0 and the current pull request of 8.3.0 is summarized in the text file.

@VisLab VisLab self-requested a review April 30, 2024 17:05
@VisLab
Copy link
Member

VisLab commented Apr 30, 2024

@neuromechanist sorry for the confusion, but could you completely remove hedId=HED_0000000. The hedId should be omitted completely for new nodes.

Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add the isPartOf schema attribute on this round?

standard_schema/prerelease/HED8.3.0.mediawiki Show resolved Hide resolved
standard_schema/prerelease/HED8.3.0.mediawiki Outdated Show resolved Hide resolved
standard_schema/prerelease/HED8.3.0.mediawiki Show resolved Hide resolved
standard_schema/prerelease/HED8.3.0.mediawiki Show resolved Hide resolved
standard_schema/prerelease/HED8.3.0.mediawiki Outdated Show resolved Hide resolved
@neuromechanist
Copy link
Member Author

@neuromechanist sorry for the confusion, but could you completely remove hedId=HED_0000000. The hedId should be omitted completely for new nodes.

Of course, they are removed.

Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the hedId. I have some questions about anatomy. The elbow does not seem to be part of the forearm and the wrist does not seem to be part of the hand, but the ankle seems to be part of the foot according to wikipedia. Confusing....

@neuromechanist
Copy link
Member Author

neuromechanist commented Apr 30, 2024

Thanks for removing the head. I have some questions about anatomy. The elbow does not seem to be part of the forearm and the wrist does not seem to be part of the hand, but the ankle seems to be part of the foot according to wikipedia. Confusing....

Joints are usually a point of debate. What we see/feel is generally the end of the bones making the joint. I don't (currently) think the joints can be independent entities under the upstream node. For example, Elbow can't be directly under the Upper-extremity-part; it should be either under Upper-arm-part or Forearm-part.

To have a consistent hierarchy, I put the proximal (that is, closer to the body core) joint under each node. Therefore, Shoulder is under Upper-arm-part, Elbow is under Forearm-part and Writst is under Hand-part.

@VisLab VisLab merged commit a52fcb9 into hed-standard:main May 3, 2024
1 check passed
@neuromechanist neuromechanist deleted the anatomy_reorg branch May 9, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants