Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with finding #208

Closed
wants to merge 4 commits into from
Closed

Fixing issue with finding #208

wants to merge 4 commits into from

Conversation

dorahermes
Copy link
Member

Replacing 'finding' with 'feature' in SCORE.

*** Rare-prevalence <nowiki>{hedId=HED_0042232} [Less than 1 percent. (Source: Beniczky ea 2017, Table 6, Table 8).]</nowiki>
*** Occasional-prevalence <nowiki>{hedId=HED_0042233} [1 to 9 percent. (Source: Beniczky ea 2017, Table 6, Table 8)]</nowiki>
*** Frequent-prevalence <nowiki>{hedId=HED_0042234} [10 to 49 percent. (Source: Beniczky ea 2017, Table 6, Table 8)]</nowiki>
*** Abundant-prevalence <nowiki>{hedId=HED_0042235} [50 to 89 percent. (Source: Beniczky ea 2017, Table 6, Table 8)]</nowiki>
*** Continuous-prevalence <nowiki>{hedId=HED_0042236} [Greater than 90 percent. (Source: Beniczky ea 2017, Table 6, Table 8)]</nowiki>
* Posterior-dominant-rhythm-property <nowiki>{suggestedTag=Finding-frequency, suggestedTag=Finding-amplitude, hedId=HED_0042237} [Posterior dominant rhythm is the most often scored EEG feature in clinical practice. Therefore, there are specific terms that can be chosen for characterizing the PDR. Note that frequency and amplitude can be further described to be symmetrical or assymetrical. (Source: Beniczky ea 2017, Section 6, Table 4.)]</nowiki>
* Posterior-dominant-rhythm-property <nowiki>{suggestedTag=Feature-frequency, suggestedTag=Feature-amplitude, hedId=HED_0042237} [Posterior dominant rhythm is the most often scored EEG feature in clinical practice. Therefore, there are specific terms that can be chosen for characterizing the PDR. Note that frequency and amplitude can be further described to be symmetrical or assymetrical. (Source: Beniczky ea 2017, Section 6, Table 4.)]</nowiki>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the assymetrical spelling as per codespell. Thx

Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I think the Finding-property --> Feature-property was particularly important as it will allow those properties to be more transparently applied across the annotations.

There are commas in the epilogue that need to be removed. It might just be the line with the initials.

@VisLab
Copy link
Member

VisLab commented Jul 12, 2024

This is superceded by PR #220 which was merged.

@VisLab VisLab closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants