Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exemplar tags #256

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Conversation

neuromechanist
Copy link
Member

I have added a couple of tags with references in the Annotation column.
I think there are some outstanding points:

  1. Should the database names also defined in the prefixes (I assume not, because the names are already available in OBO)
  2. Should we use has_dbxref or db_xref for cross-referencing (or any other label)? has_dbxref is defined here and db_xref is defined here.
  3. What should I do for the abbreviations, like LHJ and RHJ? Many of them are quite well-known and handy to use

Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first start. I am pretty sure that the links we will want to add will all be AnnotationProperty types (like has_dbxref) so we won't need any different infrastructure.

I have commented on the syntax problems above. After we finalize exactly which thing we will use, this will just need the syntax corrected.

@neuromechanist
Copy link
Member Author

Thanks Kay,

I corrected the Annotations and added obo to the prefix table.

@VisLab VisLab self-requested a review August 1, 2024 10:24
Copy link
Member

@VisLab VisLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some circular or incorrect references and other syntax errors:

  • Head-landmark lists its parent as Anatomical-landmarks. It should be Anatomical-landmark
  • Torso-chest-landmark also lists Anatomical-landmarks as it parent.
  • HED tag names cannot have blanks or parentheses. By convention only first letter is capitalized.
    • Left-helix-tragus-junction
    • Right-helix-tragus-junction
    • Vertebra-promines

The stuff in parentheses should probably go in the description.

@neuromechanist neuromechanist requested a review from VisLab August 1, 2024 16:54
@neuromechanist
Copy link
Member Author

There are some circular or incorrect references and other syntax errors:

  • Head-landmark lists its parent as Anatomical-landmarks. It should be Anatomical-landmark

  • Torso-chest-landmark also lists Anatomical-landmarks as it parent.

  • HED tag names cannot have blanks or parentheses. By convention only first letter is capitalized.

    • Left-helix-tragus-junction
    • Right-helix-tragus-junction
    • Vertebra-promines

The stuff in parentheses should probably go in the description.

Addressed!

@VisLab VisLab merged commit ab2496f into hed-standard:main Aug 2, 2024
@neuromechanist neuromechanist deleted the slam_add_sample_terms branch August 2, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants