Precompute portal node graphs #4

jere8184 · 2024-10-15T18:36:45Z

WIP

Change recommended entrypoint for Windows build

Make component classes `final`

…Input

…into uniform_syntax_change

Update syntax of GlUniformBuffer to match that of GlUniformInput SFTtech#1683

correction of a few grammatical errors and typos

Co-authored-by: Christoph Heine <6852422+heinezen@users.noreply.github.com>

Update README.md

Fix tex unit assignment to `std::optional` type

…sed.

Deactivate `_PyTraceback_Add`

Makes the updates thread-safe.

includes DbgHelp.h after windows.h to prevent errors

heinezen

A few minor points, but it already looks pretty refined.

libopenage/pathfinding/grid.cpp

libopenage/pathfinding/grid.h

libopenage/pathfinding/pathfinder.cpp

libopenage/pathfinding/pathfinder.h

…e camera movement.

… of smallest positive value.

Renderer: Added camera boundaries to CameraManager and clamping SFTtech#1682.

heinezen

Final change requests I hope :D

libopenage/pathfinding/pathfinder.cpp

libopenage/pathfinding/pathfinder.h

jere8184 · 2024-11-15T14:42:39Z

I'm now seeing a performance decrease. I've messed around with valgrind and from a quick glance I think the map look ups are causing this. :/.

edit: I've got a plan.

jere8184 · 2024-11-15T20:22:45Z

@heinezen feel free to take a look, pretty decent performance increase observed :)

heinezen · 2024-11-18T01:41:18Z

Nice, I think this should be ready now :) We can always improve the code later.

I have just a few requests before merging:

You should format you code with clamg-format one last time (and I still can really recommend to turn autoformat on in whatever IDE you are using)
Since Integrate flow field pathfinder into game simulation SFTtech/openage#1656 got merged, the code from the target is now in the openage main repo, so it would be good to reopen the PR there (and target master)

heinezen and others added 30 commits September 8, 2024 01:29

gamestate: Make component classes 'final'.

170e43f

doc: Change recommended entrypoint for Windows build.

44952e5

Merge pull request SFTtech#1689 from heinezen/fix/win_build_instructions

81a0a55

Change recommended entrypoint for Windows build

Merge pull request SFTtech#1687 from heinezen/feature/final_components

380d2e9

Make component classes `final`

renderer: Update syntax of GlUniformBuffer to match that of GlUniform…

c6db4fb

…Input

renderer: Update syntax of GlUniformBuffer to match that of GlUniform…

6256c66

…Input

Added syntax changes to GlUniformBufferInput class.

623554e

Merge branch 'uniform_syntax_change' of github.com:EdvinLndh/openage …

0c1a368

…into uniform_syntax_change

Changed uniforms attribute from unordered_map to vector

de212cb

Merge pull request SFTtech#1690 from EdvinLndh/uniform_syntax_change

66098ce

Update syntax of GlUniformBuffer to match that of GlUniformInput SFTtech#1683

Update README.md

b3a21a3

correction of a few grammatical errors and typos

Update README.md

8bad4db

Co-authored-by: Christoph Heine <6852422+heinezen@users.noreply.github.com>

Update README.md

e8bf591

Co-authored-by: Christoph Heine <6852422+heinezen@users.noreply.github.com>

Merge pull request SFTtech#1694 from PRIYANKjakharia/patch-1

02d3242

Update README.md

renderer: Fix tex unit assignment for std::optional type.

03c1592

Merge pull request SFTtech#1695 from heinezen/fix/texunit_binding

fb88dfc

Fix tex unit assignment to `std::optional` type

buildsys: Remove unused imports.

ac2dbbd

buildsys: Deactivate _PyTraceback_Add import.

ce1f7f8

buildsys: Add comments explaining why _PyTraceback_Add is no longer u…

98908b0

…sed.

Merge pull request SFTtech#1697 from heinezen/fix/py_traceback

a3df307

Deactivate `_PyTraceback_Add`

doc: Update macOS build instructions.

8d5629a

ci: Update macOS CI config.

a66e08b

ci: Update versions of deprecated actions.

656ce84

renderer: Fix lock of resource reads in render entity.

f9ec53b

renderer: Add RenderEntity base class for common methods.

cfd835f

refactor: Shorten render entity class name in HUD render stage.

d44f903

refactor: Shorten render entity class name in Terrain render stage.

3f73385

refactor: Shorten render entity class name in world render stage.

b3295e3

renderer: Return copies instead of referenced in terrain render enity.

5e7a768

Makes the updates thread-safe.

renderer: Fix lock of resource reads in hud render entity.

8314b6c

Merge pull request SFTtech#1705 from jere8184/rearrange_dbghelp

d023a2f

includes DbgHelp.h after windows.h to prevent errors

heinezen requested changes Nov 7, 2024

View reviewed changes

EdvinLndh and others added 12 commits November 7, 2024 22:54

Renderer: Added camera boundaries to CameraManager and clamping to th…

73f06b7

…e camera movement.

Refactoring and documentation.

85918c9

Added constructor for CameraBoundaries.

b907a7d

Struct refactoring

780949f

Refactoring and cleanup

1556502

Changed default minimum boundary to be largest negative value instead…

0c129fb

… of smallest positive value.

Fixes for Y boundary

59cee6a

renderer: Create boundaries.cpp file for compilation checks.

af804e6

renderer: Add method to change camera boundaries in cam manager.

179e1ad

renderer: Rename current hardcoded camera boundaries.

6d6a2dd

Include missing email for SFTtech#1691

a3376ca

Merge pull request SFTtech#1691 from EdvinLndh/add_camera_boundaries

2170ff5

Renderer: Added camera boundaries to CameraManager and clamping SFTtech#1682.

jere8184 force-pushed the precompute_portal_node_graphs branch 2 times, most recently from b2552cb to 64790d4 Compare November 9, 2024 01:39

jere8184 requested a review from heinezen November 10, 2024 18:53

heinezen requested changes Nov 13, 2024

View reviewed changes

libopenage/pathfinding/pathfinder.cpp Outdated Show resolved Hide resolved

libopenage/pathfinding/pathfinder.h Outdated Show resolved Hide resolved

libopenage/pathfinding/pathfinder.h Outdated Show resolved Hide resolved

jere8184 force-pushed the precompute_portal_node_graphs branch 2 times, most recently from 7cc49be to d0b8fb9 Compare November 14, 2024 20:26

jere8184 force-pushed the precompute_portal_node_graphs branch from d0b8fb9 to 0763aaf Compare November 15, 2024 14:48

jere8184 requested a review from heinezen November 16, 2024 16:41

jere8184 force-pushed the precompute_portal_node_graphs branch from f3003dc to 6d232d9 Compare November 18, 2024 11:19

Pathfinding: Precomputeportal nodes for A Star

28a3c95

jere8184 force-pushed the precompute_portal_node_graphs branch from 6d232d9 to 28a3c95 Compare November 18, 2024 11:28

jere8184 closed this Nov 18, 2024

heinezen mentioned this pull request Nov 18, 2024

Pathfinding: Precomputeportal nodes for A Star SFTtech/openage#1708

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Precompute portal node graphs #4

Precompute portal node graphs #4

jere8184 commented Oct 15, 2024 •

edited

Loading

heinezen left a comment

heinezen left a comment

jere8184 commented Nov 15, 2024 •

edited

Loading

jere8184 commented Nov 15, 2024

heinezen commented Nov 18, 2024

Precompute portal node graphs #4

Precompute portal node graphs #4

Conversation

jere8184 commented Oct 15, 2024 • edited Loading

heinezen left a comment

Choose a reason for hiding this comment

heinezen left a comment

Choose a reason for hiding this comment

jere8184 commented Nov 15, 2024 • edited Loading

jere8184 commented Nov 15, 2024

heinezen commented Nov 18, 2024

jere8184 commented Oct 15, 2024 •

edited

Loading

jere8184 commented Nov 15, 2024 •

edited

Loading