Return ErrorCode::EmptyPath when path has too few points

heitzmann · Nov 23, 2024 · 698bf15 · 698bf15
1 parent 9822a51
commit 698bf15
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/include/gdstk/utils.hpp b/include/gdstk/utils.hpp
@@ -69,6 +69,7 @@ enum struct ErrorCode {
     NoError = 0,
     // Warnings
     BooleanError,
+    EmptyPath,
     IntersectionNotFound,
     MissingReference,
     UnsupportedRecord,

diff --git a/python/gdstk_module.cpp b/python/gdstk_module.cpp
@@ -51,6 +51,9 @@ static int return_error(ErrorCode error_code) {
         case ErrorCode::NoError:
             return 0;
         // Warnings
+        case ErrorCode::EmptyPath:
+            if (PyErr_WarnEx(PyExc_RuntimeWarning, "Empty path.", 1) != 0) return -1;
+            return 0;
         case ErrorCode::MissingReference:
             if (PyErr_WarnEx(PyExc_RuntimeWarning, "Missing reference.", 1) != 0) return -1;
             return 0;

diff --git a/src/flexpath.cpp b/src/flexpath.cpp
@@ -239,7 +239,7 @@ void FlexPath::remove_overlapping_points() {
 
 ErrorCode FlexPath::to_polygons(bool filter, Tag tag, Array<Polygon*>& result) {
     remove_overlapping_points();
-    if (spine.point_array.count < 2) return ErrorCode::NoError;
+    if (spine.point_array.count < 2) return ErrorCode::EmptyPath;
 
     const Array<Vec2> spine_points = spine.point_array;
     uint64_t curve_size_guess = spine_points.count * 2 + 4;
@@ -774,7 +774,7 @@ ErrorCode FlexPath::to_gds(FILE* out, double scaling) {
 
     remove_overlapping_points();
 
-    if (spine.point_array.count < 2) return error_code;
+    if (spine.point_array.count < 2) return ErrorCode::EmptyPath;
 
     uint16_t buffer_end[] = {4, 0x1100};
     big_endian_swap16(buffer_end, COUNT(buffer_end));
@@ -918,7 +918,7 @@ ErrorCode FlexPath::to_oas(OasisStream& out, OasisState& state) {
 
     remove_overlapping_points();
 
-    if (spine.point_array.count < 2) return error_code;
+    if (spine.point_array.count < 2) return ErrorCode::EmptyPath;
 
     bool has_repetition = repetition.get_count() > 1;