[TASK] Only read override settings file if it has config #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helhum
force-pushed
the
schloram-patch-1
branch
from
7a60e6d
to
d1612f6
Compare
In out setup we don't use the `defaultConfiguration` step but use the use the `SetupConfigurationAction` to set `customOverrideSettings`. Because of the missing `defaultConfiguration` step the `override.settings.yaml` was not created before the `SetupConfigurationAction` got executed. In this case `readConfig()` throws an error that the file does not exist. Therefore we have to check if the file has config before reading it.
helhum
force-pushed
the
schloram-patch-1
branch
from
d1612f6
to
b9220de
Compare
Hm, I won't recommend that. The DefaultConfiguration action in TYPO3 core does way more than the name suggests. I therefore would not skip that, unless you have some test scenario or replicate the steps done there within a custom action. |
|
Your code change is fine though. It does not harm to check the overrides file exists before modifying it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our setup we don't use the
defaultConfigurationstep but use the use theSetupConfigurationActionto setcustomOverrideSettings.Because of the missing
defaultConfigurationstep theoverride.settings.yamlwas not created before theSetupConfigurationActiongot executed. In this casereadConfig()throws an error that the file does not exist.Therefore we have to check if the file has config before reading it.