This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Up the limit of random connections to gossip #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems to solve: Currently we are gossiping a maximum of 8 connections which is not a lot on something like a seed node where may have 10,000 or more. Additionally,
lists/sublist/2allows for the length of a sublist to be longer than the input - so using a conditional doesn't make much sense (except to avoid the randomization/sorting but on a short list, it costs almost nothing anyway).Solution: Up to the default limit to 200, remove the conditional test. In my testing on this, we could probably store closer to 1500 connections and be under the 50 kb gossip limit.
Addresses #352