Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log a warning when signal is already registered #46

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Log a warning when signal is already registered #46

merged 1 commit into from
Aug 9, 2024

Conversation

lboquillon
Copy link
Contributor

As discussed on #36: a warn is logged rather than throwing an error.

@lboquillon
Copy link
Contributor Author

Hi @StarpTech,
did you have the chance to look at it?
Thanks!

StarpTech
StarpTech requested changes Aug 9, 2024
View reviewed changes
index.js Outdated Show resolved Hide resolved
@lboquillon
Copy link
Contributor Author

@StarpTech done!

StarpTech
StarpTech approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StarpTech StarpTech merged commit 8e1e6e0 into hemerajs:master Aug 9, 2024
1 check passed
@lboquillon
Copy link
Contributor Author

Hi @StarpTech,
any chance of release a new version with this change? I can do any work needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarpTech StarpTech StarpTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lboquillon @StarpTech