-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to add stats to Job Summary page #263
Add option to add stats to Job Summary page #263
Conversation
Nice! Do you see a reason why somebody would decide against this? I understand the need for the version check. Given that the version supports it, I would enable it. Or do I miss anything? Is there a usecase for disabling the output? |
No problem. Just being conservative - I'll update the PR enabling the feature by default. |
# Conflicts: # dist/restore/index.js # dist/save/index.js # package-lock.json # package.json
I've done something similar for a private repo, Something that I found looks really good is to use a mermaid diagram to show the direct/preprocessed/missed stats in a pie chart diagram. https://mermaid.js.org/syntax/pie.html Since the summaries support github flavoured markdown they render right in the summary view! e.g.
pie showData title CCache Summary
"Direct Hits" : 149818
"Preprocessed Hits" : 1840
"Misses" : 3743
|
@planetmarshall Thanks again for the contribution. I think this ready to be merged, however I meanwhile merged some dependabot PRs and caused a merge conflict. Shall I fix it myself or can you? |
# Conflicts: # package-lock.json # package.json
I've updated the branch.
I like the the idea but I think it's better added as a future enhancement. |
Adds a
job-summary
option that adds the stats to the Job Summary section of a workflow run. Requires CCache 4.10+Also added some unit tests and a workflow job for same.
Just added cache hits for now but is easily extendable. - looks like this: