Improve error handling and log output of {pre,post}_compile hooks
#1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If the hooks fail, there is now an explicit error message (plus metrics event). * The build log step now references the full script location to aid. with understanding of what's happening. * Any output of the hooks is now indented to aid readability. * The hooks implementation has been refactored and moved to `lib/` as part of the overall buildpack reorganisation/refactoring. * Test coverage has been added for the failing hooks cases (previously only the successful hooks scenario was tested). (This is one step towards ensuring all buildpack failure cases have an explicit error message and a metrics `failure_reason`.) GUS-W-8059892.
edmorley
force-pushed
the
handle-hook-errors
branch
from
6a039aa to
4d43b6f
Compare
Malax
approved these changes
Oct 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/as part of the overall buildpack reorganisation/refactoring.(This is one step towards ensuring all buildpack failure cases have an explicit error message (rather than relying on the error message of the command that failed) and a metrics
failure_reason.)GUS-W-8059892.