Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include dotfiles in error message file listings #1728

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Jan 2, 2025

The error messages shown when buildpack detection fails (or when detection passes, but no required package manager files are found later) include a file listing of the project to help with debugging. (e.g. to make misspellings or having forgotten to commit files more obvious.)

Previously these file listings didn't include dotfiles, which meant not all project files would be shown. This is particularly relevant given that the the newly supported .python-version file is a dotfile.

GUS-W-17524155.

The error messages shown when buildpack detection fails
(or when detection passes, but no required package manager
files are found later) include a file listing of the project to help
with debugging, (eg to make misspellings or having forgotten
to commit files more obvious.)

Previously these file listings didn't include dotfiles, which
meant not all project files would be shown. This is particularly
relevant given that the the newly supported `.python-version`
file is a dotfile.
@edmorley edmorley self-assigned this Jan 2, 2025
@edmorley edmorley marked this pull request as ready for review January 2, 2025 15:56
@edmorley edmorley requested a review from a team as a code owner January 2, 2025 15:56
@edmorley edmorley enabled auto-merge (squash) January 2, 2025 16:33
@edmorley edmorley merged commit f686af6 into main Jan 2, 2025
8 checks passed
@edmorley edmorley deleted the list-dotfiles branch January 2, 2025 16:46
@heroku-linguist heroku-linguist bot mentioned this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants