This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Fix white on white text #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +23,9 @@ body { | |||
| margin-bottom: 90px; | |||
| color: fade-out($white, 0.2); | |||
| } | |||
| .panel { | |||
| color: #3F3F44; | |||
There was a problem hiding this comment.
Color literals like #3F3F44 should only be used in variable declarations; they should be referred to via variable everywhere else.
Color #3F3F44 should be written as #3f3f44
| @@ -72,5 +72,9 @@ class Design < Sinatra::Base | |||
| slim :"design/index" | |||
| end | |||
| end | |||
|
|
|||
| def client_deny_url | |||
| "https://id.heroku.com/#deny" | |||
There was a problem hiding this comment.
How is that relevant to the white on white css bug?
There was a problem hiding this comment.
I needed this fix to test the authorization endpoint in our design since the view calls this method.
https://github.com/heroku/identity/blob/master/lib/identity/design.rb#L51-L54
|
👍 |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225 and #227
This also fixes the design view of authorize client (http://localhost:5000/design/authorize when running locally)
Ready for review @heroku/api