Skip to content

Commit

Permalink
fix(Range): Fix Monk range checking
Browse files Browse the repository at this point in the history 
- Use Provoke instead of Clash for 30y, as both specs always have Provoke
- Add Backout Kick (Brewmaster) as a backup for Tiger Palm, as PTA replaces Tiger Palm
  • Loading branch information
@Cilraaz
Cilraaz committed Nov 19, 2023
1 parent 57944f5 commit 991088c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion HeroLib/Class/Unit/Range.lua
View file
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ RangeTableBySpell = {
SpellRange = {
[5] = {
100780, -- Tiger Palm
205523, -- Blackout Kick (Brewmaster - PTA replaces Tiger Palm)
},
[8] = {
113656, -- Fists of Fury
Expand All @@ -312,7 +313,7 @@ RangeTableBySpell = {
122470, -- Touch of Karma
},
[30] = {
324312, -- Clash
115546, -- Provoke
},
[40] = {
117952, -- Crackling Jade Lightning
Expand Down

2 comments on commit 991088c

@remmody
Copy link

@remmody remmody commented on 991088c Nov 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix, on the contrary, broke the distance check
I'm checking the player for
/dump HeroLib.Unit("player"):IsInRange(40)
I get false
similarly with other units

upd.:
I play Mistweaver
udp2.:
the check works on enemies, but does not work on allies

@Cilraaz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix, on the contrary, broke the distance check I'm checking the player for /dump HeroLib.Unit("player"):IsInRange(40) I get false similarly with other units

upd.: I play Mistweaver udp2.: the check works on enemies, but does not work on allies

No range checks work on allies currently (aside from possibly Living Flame for Evokers). That hasn't been worked back into the range checking system as of yet.

Please sign in to comment.