fix(theme): add missing shadow none

[wingkwong]

Closes #4586

📝 Description

As title, following the doc.

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

Release Notes

• New Features

  • Added none shadow variant for Modal and Popover components
  • Enhanced styling flexibility by allowing components to be rendered without shadows

• Dependency Updates

  • Updated @heroui/theme to address styling configuration

This update provides more granular control over component styling, allowing developers to easily remove shadows from Modal and Popover components when needed.

[linear]

ENG-1904 [BUG] - Modal prop "shadow" doesn't accept "none"

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
heroui	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Jan 18, 2025 0:39am
heroui-sb	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 18, 2025 0:39am

[changeset-bot]

🦋 Changeset detected

Latest commit: 5586c33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages

Name	Type
@heroui/theme	Patch
@heroui/autocomplete	Patch
@heroui/checkbox	Patch
@heroui/date-input	Patch
@heroui/date-picker	Patch
@heroui/form	Patch
@heroui/input-otp	Patch
@heroui/input	Patch
@heroui/radio	Patch
@heroui/select	Patch
@heroui/table	Patch
@heroui/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request addresses an issue with the @heroui/theme package by adding a none variant to the shadow property for both modal and popover components. This change introduces a new styling option that allows users to remove shadows from these components, resolving a previous limitation where "none" was not a valid shadow configuration.

Changes

File	Change Summary
.changeset/stale-bears-wink.md	Patch update for @heroui/theme dependency
packages/core/theme/src/components/modal.ts	Added none variant to shadow property with "shadow-none" base class
packages/core/theme/src/components/popover.ts	Added none variant to shadow property with "shadow-none" content class

Assessment against linked issues

Objective	Addressed	Explanation
Add "none" as a valid shadow option for Modal [#4586]	✅
Resolve Typescript type constraint for shadow prop	✅

The changes comprehensively address the requirements outlined in issue #4586 by introducing the none variant for the shadow property in both modal and popover components, thereby resolving the type and styling limitations previously reported.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2036878 and 5586c33.

📒 Files selected for processing (3)

• .changeset/stale-bears-wink.md (1 hunks)
• packages/core/theme/src/components/modal.ts (1 hunks)
• packages/core/theme/src/components/popover.ts (1 hunks)

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.