Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增加系统配置项,使前端可以调整dml是否经过DBA审批 #2284

Closed
wants to merge 2 commits into from

Conversation

database-on-line
Copy link

作为一名DBA来说,其实对于业务并没有业务leader熟悉,所以加了这个开关控制,可以对行数较少的dml不经过DBA审批,既能增加业务审批的速度,又能减少DBA的工作量

Copy link
Owner

@hhyo hhyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个场景确实比较多,可以作为免批的补充

@hhyo hhyo self-requested a review September 1, 2023 14:19
Copy link
Owner

@hhyo hhyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先把修复ci一下

@database-on-line
Copy link
Author

好的,我看下哪里出问题重新跑下吧,改动不大,不知道为啥出现了docker编译报错和测试用例没通过,我再看看

@peng19832
Copy link
Contributor

image
这个,可以通过配置项实现,也还行

@LeoQuote
Copy link
Collaborator

LeoQuote commented Nov 7, 2023

你好, 感谢你的 pr, 最新的 master 分支已经支持深度审批流自定义, 在 settings 内部可以设置需要采用的审批流对象, 此时你可以指定一个你自己实现的 自定义对象, 详见 #2348

依然欢迎你分享自己觉得有价值的审批流配置, 供其他人使用或参考.

class CustomAudit(AuditV2):
    def generate_audit_setting(self):
        ...

@LeoQuote LeoQuote closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants