Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2406 +/- ##
=======================================
Coverage 76.34% 76.34%
=======================================
Files 115 115
Lines 15852 15852
=======================================
Hits 12103 12103
Misses 3749 3749 ☔ View full report in Codecov by Sentry. |
|
由于 bug 是前端 bug, 我这边在 pg 上测试了一下, 响应正常, 先merge 了 |
finovy
pushed a commit
to finovy/Archery
that referenced
this pull request
Dec 1, 2023
* 修复表结构显示不正确的 bug * f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2378
fix #2402
之前的修改(#2230)中, 为了正常显示 cassandra 的表结构信息做的改动, 但是没有考虑到部分数据库的表结构信息并不是像 mysql 的一样, 如 mssql 和 oracle , pg 都是只有字段的列表, 类型, 是否主键等等. 为了兼容这种情况, 把前端重新修改了一下:
引入一个 need_describe_display 的变量, 只有在返回的结果集中, 字段列表为 "table", "create table" , 或语句和 mysql 的 show create table 类似时, 才调用显示表结构的函数, 其他情况下, 都使用普通的表格展示