Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复mongo上线问题 #2803

Merged
merged 6 commits into from
Sep 18, 2024
Merged

修复mongo上线问题 #2803

merged 6 commits into from
Sep 18, 2024

Conversation

smqyisyy
Copy link
Contributor

@smqyisyy smqyisyy commented Sep 12, 2024

在使用未开启密码认证的实例上,会出现mongo的上线报错,因为代码中强制使用了账号密码登录的方式
找到了之前的#1893,加入几个判断可以解决,我改好了提了个pr

fix #2789

@smqyisyy smqyisyy mentioned this pull request Sep 12, 2024
@LeoQuote LeoQuote changed the base branch from fix-mongo to master September 12, 2024 06:04
Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的代码复用有点少, 能否帮忙优化一下, 渲染时先做无用户名密码的情况, 然后有用户名密码就加上对应的参数

@smqyisyy
Copy link
Contributor Author

smqyisyy commented Sep 12, 2024

#2805
新的优化改好了,可以看看是否符合预期

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.11%. Comparing base (54bb3dc) to head (f0c3726).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sql/engines/mongo.py 72.22% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2803      +/-   ##
==========================================
+ Coverage   78.05%   78.11%   +0.05%     
==========================================
  Files         122      123       +1     
  Lines       17286    17331      +45     
==========================================
+ Hits        13493    13538      +45     
  Misses       3793     3793              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sql/engines/mongo.py Outdated Show resolved Hide resolved
@LeoQuote
Copy link
Collaborator

lint 必须要修好哈

@smqyisyy
Copy link
Contributor Author

这里修复了lint问题了,可以看看了

Copy link
Collaborator

@LeoQuote LeoQuote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多谢贡献, build_cmd 这块逻辑有点多容易出错, 能否帮忙加一下单元测试, 因为只是字符串操作测试加起来应该不难, 请参考历史的单元测试或者 https://github.com/hhyo/Archery/wiki/development

@smqyisyy
Copy link
Contributor Author

这里历史只看到开发环境的搭建过程,不知道这个测试具体是如何操作?没有做过测试,可否细致描述一下具体流程?

@smqyisyy
Copy link
Contributor Author

这样应该是测试加入完成了?有空可以瞅瞅

@LeoQuote
Copy link
Collaborator

看完了没问题👌🏿

@LeoQuote LeoQuote merged commit 5a6871d into hhyo:master Sep 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mongodb上线有错误
2 participants