Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect variable usage in bytes decoding function #2821

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

emmanuel-ferdman
Copy link

PR Summary

PR fixes variable usage in ExtendJSONEncoderBytes from 'o' to 'obj'.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.35%. Comparing base (d97ccdc) to head (f42c4e9).

Files with missing lines Patch % Lines
common/utils/extend_json_encoder.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2821   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files         124      124           
  Lines       17580    17580           
=======================================
  Hits        13775    13775           
  Misses       3805     3805           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LeoQuote
Copy link
Collaborator

Thanks for your pr! Please add tests for the change so it can be safely merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants