Add the scheduler option HeartbeatInterval #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheduler.go
Outdated
| @@ -317,7 +335,7 @@ func (s *Scheduler) beat() { | |||
| entries = append(entries, e) | |||
| } | |||
| s.logger.Debugf("Writing entries %v", entries) | |||
| if err := s.rdb.WriteSchedulerEntries(s.id, entries, 5*time.Second); err != nil { | |||
| if err := s.rdb.WriteSchedulerEntries(s.id, entries, s.heartbeatInterval); err != nil { | |||
There was a problem hiding this comment.
From the original issue:
scheduler entries are prone to expire when redis is slow to respond
Even though this just affects the inspector, there is a small chance that the SchedulerEntries may be empty because they expired before the next beat ran. I would propose it to be such that redisKey ttl > beat tick to reduce the chance of the entries being empty at any given time.
There was a problem hiding this comment.
Absolutely, I did not want to tackle this in the same PR, but I think we should have ttl = s.heartbeatInterval * 2.
I don't have strong opinions on this, what option do you prefer:
ttl = s.heartbeatInterval * 2ttl = s.heartbeatInterval + time.Second- Or a second option
There was a problem hiding this comment.
ttl = s.heartbeatInterval * 2
This sounds good.
kamikazechaser
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
From #510:
Redo of #896
Fixes #510
Changes
SchedulerOpts.HeartbeatInterval